Regex in CheckPlayLibraryAdded Incorrectly Identifies Play Core-Common Libraries

Unity: Android

Android

Fixed

2023.3.X

2023.2.X

2023.1.X

2022.3.X

2021.3.X

[Android] Check for Play Libraries was fixed to ignore Play Core-Common libraries and only throw errors for Play Core as expected. Tests were modified following the fix, and changed for efficiency.

[Android][2023.2] Check for Play Libraries was fixed to ignore Play Core-Common libraries and only throw errors for Play Core as expected. Tests were modified following the fix, and changed for efficiency.

[Android][2023.1] Check for Play Libraries was fixed to ignore Play Core-Common libraries and only throw errors for Play Core as expected. Tests were modified following the fix, and changed for efficiency.

[Android][2022.3] Check for Play Libraries was fixed to ignore Play Core-Common libraries and only throw errors for Play Core as expected. Tests were modified following the fix, and changed for efficiency.

[Android][2021.3] Check for Play Libraries was fixed to ignore Play Core-Common libraries and only show warnings/log messages for Play Core as expected. Tests were modified following the fix, and changed for efficiency.

Reproduction:

In attached project, under Edit -> Project Settings -> Player -> Publishing Settings, enable the "Custom Main Gradle Template" checkbox
Navigate to file Assets/Plugins/Android/mainTemplate.gradle. Under the other implementation line, add this line:
implementation "com.google.android.play:core-common:2.0.0"
Enable Build App Bundle and Split Application Binary
Build and run to testing device
Observe the error messages seen in console, namely "Can't determine the version of Play Core dependency "com.google.android.play:core". Upgrade to Play Asset Delivery library to ensure it is at least version 2.0.0, which is the default version used by Unity for Play Asset Delivery.", and debug message "Detected "com.google.android.play:core" in Assets/Plugins/Android/mainTemplate.gradle. Assuming the dependency is already added".

Expected Result: No errors or messages
Actual Result: "Can't determine version..." error and debug message detecting play core library when it has not been included

Details:

CheckPlayLibraryAdded in ExtensionModule.cs uses Regex to find Google PlayCore or PlayAssetDelivery dependencies included in Gradle template files.

Due to the format of the search (mentioned in slack thread), it is confusing the "com.google.android.play:core" and "com.google.android.play:core-common" libraries, leading to "Can't determine version" and upgrade prompts. Regex needs to be fixed so as not to confuse the libraries, as the Core-Common library is unrelated to asset delivery and does not interfere if asset delivery libraries were to be added.

Reproducible Versions: 2023.3.0a1, also suspected to reproduce on: 23.2, 23.1, 22.3 and 21.3

Reproducible Devices:

Pixel 6a, CPU: Google Tensor, GPU: Mali-G78, OS: 12

Regex in CheckPlayLibraryAdded Incorrectly Identifies Play Core-Common Libraries

Unity: Android

Fixed

Prioritise and Follow this issue

Have a workaround or additional info about this issue?

Regex in CheckPlayLibraryAdded Incorrectly Identifies Play Core-Common Libraries

Unity: Android

Statuses

Fixed

Resolution Notes

2023.3.XFixed[Android] Check for Play Libraries was fixed to ignore Play Core-Common libraries and only throw errors for Play Core as expected. Tests were modified following the fix, and changed for efficiency.

2023.2.XFixed[Android][2023.2] Check for Play Libraries was fixed to ignore Play Core-Common libraries and only throw errors for Play Core as expected. Tests were modified following the fix, and changed for efficiency.

2023.1.XFixed[Android][2023.1] Check for Play Libraries was fixed to ignore Play Core-Common libraries and only throw errors for Play Core as expected. Tests were modified following the fix, and changed for efficiency.

2022.3.XFixed[Android][2022.3] Check for Play Libraries was fixed to ignore Play Core-Common libraries and only throw errors for Play Core as expected. Tests were modified following the fix, and changed for efficiency.

2021.3.XFixed[Android][2021.3] Check for Play Libraries was fixed to ignore Play Core-Common libraries and only show warnings/log messages for Play Core as expected. Tests were modified following the fix, and changed for efficiency.

Description

Prioritise and Follow this issue

Have a workaround or additional info about this issue?